Skip to content

Conversation

@avosalmon
Copy link

@avosalmon avosalmon commented Feb 6, 2025

This PR updates actions/checkout in GitHub Actions and fixes some TS errors.

</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" rounded="xl">
<DropdownMenuContent align="end">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DropdownMenuContent does not have the rounded prop.
CleanShot 2025-02-06 at 10 12 44


<footer className="py-16 text-center text-sm text-black dark:text-white/70">
Laravel v{laravelVersion} (PHP v{phpVersion})
Laravel v{laravelVersion as string} (PHP v{phpVersion as string})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes this TS error.
CleanShot 2025-02-06 at 10 10 58

<SidebarMenuButton asChild isActive={item.url === page.url}>
<Link href={item.url} prefetch>
<item.icon />
{item.icon && <item.icon />}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes this.

CleanShot 2025-02-06 at 10 23 16

@avosalmon
Copy link
Author

@tnylea There is an error in resources/js/pages/auth/verify-email.tsx. We need to pass the title and description to the AuthLayout but I'll leave it to you.

CleanShot 2025-02-06 at 10 23 54

@avosalmon avosalmon requested a review from tnylea February 6, 2025 01:27
@tnylea
Copy link
Contributor

tnylea commented Feb 6, 2025

Thanks @avosalmon!

I got the title and description passed to the Layout in the verify email component. I've also updated the lint file to auto-commit. Feel free to send over any additional feedback on how this might be improved 🤘

I'll chat more with ya on Slack 😉

@tnylea tnylea merged commit a2391d2 into develop Feb 6, 2025
2 checks passed
@taylorotwell taylorotwell deleted the github-actions branch February 14, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants